fix: added support for bindings in invokeAPI #1024
Conversation
🦋 Changeset detectedLatest commit: 904fc3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit 904fc3c): https://react-kitchen-sink-dev--pr1024-848-use-bindings-in-q97gh7s9.web.app (expires Wed, 12 Feb 2025 14:44:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
| @@ -21,8 +22,14 @@ export const invokeAPI = async ( | |||
| setter?: Setter, | |||
| options?: InvokeAPIOptions, | |||
| ): Promise<Response | undefined> => { | |||
| const evaluated = evaluateDeep( | |||
There was a problem hiding this comment.
How does this work with the useInvokeAPI hook? That hook clearly checks if the API name exists before invoking.
There was a problem hiding this comment.
if you check useEnsembleAction, in useInvokeAPI we are using useRegisterBindings for evaluate API name and then we check that is API name exists in screenContext before invoking the api, and here when user trigger the api through ensemble.invokeAPI, we are using evaluateDeep to evaluate the api name and then we are checking that name with screenContext and if we found the api, only then we invoke it
Describe your changes
Added support for bindings in invokeAPI
Screenshots [Optional]
Issue ticket number and link
Closes #848
Checklist before requesting a review
pnpm changeset add