🧪 Add testing coverage for poseCollide in ColliderMap#8
Conversation
- Installed `jest`, `ts-jest`, and `@types/jest` properly into the project. - Configured a new jest runner. - Wrote unit tests for `poseCollide` covering basic coordinates, unknown maps, The Skeld specific logic, path intersections, and doors collision handling. - Converted `path-intersection` to an ES-module safe require default wrapper so the Node.js test environment processes it alongside standard bundlers properly. Co-authored-by: Er1ckW <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap in
src/common/ColliderMap.tsregarding theposeCollidefunction. The function relies heavily on mapping vectors over SVG paths using an intersection library (path-intersection) and previously lacked verification in logic.📊 Coverage:
yarn testvalidation.UNKNOWN, undefined maps likeSUBMERGED).THE_SKELD_APRILvector coordinate flip mechanism.jest.mock, and doors state array parsing (where an intersection respects whether the specific map door acts as a wall).✨ Result: A significant improvement in the safety net surrounding core map/player coordinate translation and math resolution, laying the groundwork for more unit testing and preventing future regressions in door logic.
PR created automatically by Jules for task 8954064399220484862 started by @Er1ckW