Added sell multipliers #4770
Merged
Added sell multipliers #4770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature request @ EssentialsX#3934
JRoy
requested changes
Sep 3, 2023
Member
JRoy
left a comment
There was a problem hiding this comment.
also needs to account for sell sign
Essentials/src/main/java/com/earth2me/essentials/commands/Commandsell.java
Outdated
Show resolved
Hide resolved
|
Can we please get sell multipliers implemented to latest essentialsx? |
…l-multipliers-redo # Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Settings.java
JRoy
approved these changes
Dec 9, 2024
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Josh Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #3934
Details
Proposed feature:
Sell multipliers! The idea is for servers to be able to control how much players can /sell their items for based on configurable permissions. I re-wrote this based on @Chew's feedback to work more similarly to the multiple set-home system so that it doesn't have to iterate over all of a players' permissions and instead, check if they have the ones in the config.
#3934
Environments tested:
OS: Windows 10
Java version: OpenJDK 17.0.1
Demonstration:
Screenshot: https://i.imgur.com/ju0jMUy.png
Here I give myself a diamond and sell it with no permissions (as op), then I give myself the "essentials.sell.multiplier.double" permission and as you can see, my sell price is double.
Plugin Download: https://www.dropbox.com/s/56y3zf6ibarlwj4/EssentialsX-2.19.3-dev%2B6-739600e-sell-multipliers-redo.jar?dl=0