Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement chat message signing for 1.19.1+ #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdcfe merged 8 commits into from
Aug 6, 2022
Merged

Implement chat message signing for 1.19.1+ #5030

mdcfe merged 8 commits into from
Aug 6, 2022

Conversation

@mdcfe
Copy link
Member

@mdcfe mdcfe commented Aug 2, 2022 •
edited
Loading

Information

This PR refactors EssentialsX Chat in order to support chat previews and signed chat messages in 1.19.1.

Details

Environments tested:

  • Most recent Paper version (1.19.1, git-Paper-102)
  • Paper 1.18.2 (git-Paper-387)

Demonstration:

Regular formatted chat is signed
Local chat, /toggleshout and shout/question prefix messages all signed

@mdcfe mdcfe added the type: enhancement Features and feature requests. label Aug 2, 2022
@mdcfe mdcfe added this to the 2.19.5 milestone Aug 2, 2022
@mdcfe mdcfe requested a review from JRoy August 2, 2022 19:55
JRoy
JRoy requested changes Aug 2, 2022
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first skim

@mdcfe mdcfe mentioned this pull request Aug 3, 2022
Closed
@mdcfe mdcfe marked this pull request as ready for review August 6, 2022 15:49
@mdcfe mdcfe requested a review from JRoy August 6, 2022 15:50
@mdcfe
Copy link
Member Author

mdcfe commented Aug 6, 2022

Known issue: this inadvertently reformats /minecraft:tell. There's not much we can do about this in 2.19.x.

@mdcfe mdcfe merged commit 6dfa18c into 2.x Aug 6, 2022
@mdcfe mdcfe deleted the feature/chat-signing branch August 6, 2022 21:28
@Pantera07
Copy link
Contributor

Pantera07 commented Aug 7, 2022

2022-08-07_17 46 54

[17:46:50] [Async Chat Thread - #0/INFO]: Mad_Daniel: test
[17:46:57] [Server thread/INFO]: [Essentials] CONSOLE issued server command: /ess version
[17:46:57] [Server thread/INFO]: Server version: 1.19.2-R0.1-SNAPSHOT git-Paper-113 (MC: 1.19.2)
[17:46:57] [Server thread/INFO]: Brand version: Paper
[17:46:57] [Server thread/INFO]: EssentialsX version: 2.19.5-dev+38-6dfa18c
[17:46:57] [Server thread/INFO]: Vault version: 1.7.3-b131
[17:46:57] [Server thread/INFO]: EssentialsXChat version: 2.19.5-dev+38-6dfa18c
[17:46:57] [Server thread/INFO]: Economy Layer: None
[17:46:57] [Server thread/INFO]: Fetching version information...
[17:46:57] [Craft Scheduler Thread - 2 - Essentials/INFO]: You're running the latest EssentialsX dev build!
[17:50:03] [Server thread/INFO]: Plugins (3): Essentials, EssentialsChat, Vault

How can I solve this?

@mdcfe
Copy link
Member Author

mdcfe commented Aug 7, 2022

[...]

How can I solve this?

@Pantera07 Did you enable previews in your server.properties?

@Pantera07
Copy link
Contributor

Pantera07 commented Aug 7, 2022

[...]
How can I solve this?

@Pantera07 Did you enable previews in your server.properties?

thank! I enable previews and this issue is resolved.

@osfanbuff63 osfanbuff63 mentioned this pull request Aug 7, 2022
Closed
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
@mdcfe
Implement chat message signing for 1.19.1+ (EssentialsX#5030)
107e69f 
**Known issue: this inadvertently reformats `/minecraft:tell`. There's not much we can do about this in 2.19.x.**

This commit refactors EssentialsX Chat in order to support chat previews and signed chat messages in 1.19.1+.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoy JRoy JRoy approved these changes

Assignees

No one assigned

Labels

type: enhancement Features and feature requests.

Projects

None yet

Milestone

2.19.5

Development

Successfully merging this pull request may close these issues.

4 participants

@mdcfe @Pantera07 @JRoy