Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented Jun 1, 2023

This will throw an AbstractMethodError and doesn't make much sense to check anyway

Fixes #5374

This will throw an AbstractMethodError and doesn't
make much sense to check anyway
@JRoy JRoy added the module: main Issues or PRs for the main Essentials module label Jun 1, 2023
@JRoy JRoy added this to the 2.20.1 milestone Jun 1, 2023
@JRoy JRoy added the type: bugfix PRs that fix bugs in EssentialsX. label Jun 1, 2023
@imDaniX
Copy link
Contributor

imDaniX commented Jun 4, 2023

Doesn't Player extend OfflinePlayer, so it will always return true now?

@mdcfe
Copy link
Member

mdcfe commented Jun 4, 2023

Doesn't Player extend OfflinePlayer, so it will always return true now?

The OfflinePlayer class here is the stub inside EssentialsX, not the Bukkit OfflinePlayer

@JRoy JRoy merged commit a1fa1e3 into EssentialsX:2.x Jul 1, 2023
@JRoy JRoy deleted the fix/visability-checks-ame branch July 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception when responding to an offline player via /reply

4 participants