Add min tel parameter to xgboost settings#191
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for selecting an XGBoost stereo friend-tree file variant based on a “minimum telescope multiplicity” run parameter, so the effective area step can load the correct .xgb_stereo_mintelN.root input.
Changes:
- Extend
makeEffectiveArea’s data chain loader to append an optional_mintel<min_tel>suffix when adding the XGB stereo friend chain. - Add
fReconstructionMinTelrun parameter, parse it optionally afterRECONSTRUCTIONTYPE XGBSTEREO, and print it in the run parameter summary. - Add a changelog fragment documenting the new capability.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/makeEffectiveArea.cpp |
Threads min_tel into XGB file selection and constructs the _mintelN filename variant. |
src/VInstrumentResponseFunctionRunParameter.cpp |
Initializes/reads/prints the new fReconstructionMinTel parameter. |
inc/VInstrumentResponseFunctionRunParameter.h |
Adds the new member and bumps ROOT class version. |
docs/changes/191.feature.md |
Documents the new min-tel option for XGB input selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an additional parameter for the effective area step to select the correct xgboost file.