fix: Open source Feast dev sync #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: pybuild-deps throws errors w/ latest pip version Signed-off-by: Tommy Hughes <[email protected]>
…feast-dev#5308) * Add feature view lineage tab and filtering to home page lineage Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix TypeScript errors in lineage visualization components Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format FeatureViewLineageTab.tsx Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…o work with the latest import paths (feast-dev#5315) Signed-off-by: Dan Baron <[email protected]>
* Improve search UI: relocate search bar, add command+k shortcut, enhance UX Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix TypeScript errors in search components Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix inputRef handling in RegistrySearch component Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format code with prettier Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add search button to sidebar for easier access Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format Layout.tsx with prettier Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix search bar width and center it Co-Authored-By: Francisco Javier Arceo <[email protected]> * Remove redundant search indicator from search bar Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format Layout.tsx with yarn format Co-Authored-By: Francisco Javier Arceo <[email protected]> * Remove Search (⌘K) text from sidebar button Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add ⌘K indicator to search input and remove magnifying glass from navbar Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix theme toggle position to be left-justified Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…rrow deps (feast-dev#5318) chore: Use hermeto generic fetcher for offline arrow source build Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
…#5320) * Feature: Add permissions display to Feast UI lineage visualization Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format code with Prettier Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix TypeScript errors in getEntityPermissions function Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add permissions for zipcode_features, zipcode_source, and model_v1 Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add permissions page and display permissions on feature service page Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add mock permissions data for development Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add permissions display to feature view pages Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add permissions display to entity pages Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add permissions display to data source pages Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix permissions implementation with separate apply_permissions.py script Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Comment out NPM_TOKEN requirement in .npmrc for easier local development Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Add permissions display to features page and fix icon loading errors Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update: EUI package to fix icon loading errors Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Remove theme import to resolve icon loading errors Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Update package dependencies to resolve icon loading errors Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add Home | Lineage link and update permission utils Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add RAG project with feature views and permissions Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update feature_store.yaml for RAG project Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update: Move Home and Lineage links to sidebar navigation Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update: Remove Home | Lineage links from top of page Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add: RAG data files for document embeddings and metadata Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Update sidebar navigation to show Home | Lineage as a single item Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Update Home | Lineage navigation to appear as a single line with two links Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Update sidebar navigation to fix React Hook error Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Update Lineage link to use feature service demo tab URL format Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Update Lineage link to properly redirect to the lineage tab Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update: Add data files to .gitignore Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update: Move Lineage to its own page under Resources in sidebar Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update: Remove Home hyperlink and Lineage tab from home page Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format: Run yarn format to ensure code follows project standards Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* Fix: Entity filtering and permissions in the Lineage tab Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update PR to clarify fix scope Co-Authored-By: Francisco Javier Arceo <[email protected]> * Remove entity filtering from Feature View Lineage tab Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Signed-off-by: Suraj Patil <[email protected]>
* Add RAG Project to projects-list.json Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update RAG Project to use custom registry with unique feature views Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update RAG Project to use binary registry file Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update RAG Project to use JSON registry file Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update RAG registry JSON format to match expected structure Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update useLoadRegistry to handle JSON registry files Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format code with yarn format Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix useLoadRegistry.ts to maintain compatibility with tests Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update mock handlers to ensure tests pass Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix mock handlers to use correct registry path Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update mock handlers to support both registry paths Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update FeastUISansProviders.test.tsx to include creditHistoryRegistryDB handler Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix tests to handle both binary and JSON registry files Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix feature view rendering in test environment Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format code with yarn format Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update projects order, fix data sources, and remove Home hyperlink Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix feature view detail page by adding batchSource to feature views Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…dev#5325) Signed-off-by: Tommy Hughes <[email protected]>
* Improve search results formatting for better readability and user experience Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix TypeScript errors with CSS implementation in search results Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add feature to clear search bar after clicking a result Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix linting issues in RegistrySearch component Co-Authored-By: Francisco Javier Arceo <[email protected]> * Implement command palette/spotlight search triggered by Cmd+K Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix TypeScript errors in CommandPalette component Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix UI issues in command palette: prevent double scrollbars and improve modal positioning Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix command palette overlay implementation and UI issues Co-Authored-By: Francisco Javier Arceo <[email protected]> * Remove unused EuiOverlayMask import Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix command palette UI issues and improve user experience Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix command palette modal closing when clicking on search results Co-Authored-By: Francisco Javier Arceo <[email protected]> * Apply formatting to command palette components Co-Authored-By: Francisco Javier Arceo <[email protected]> * Use React Router navigation instead of window.location.href to prevent full page refreshes Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format CommandPalette.tsx and clean up code Co-Authored-By: Francisco Javier Arceo <[email protected]> * Remove test button from Layout component Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…offline builds (feast-dev#5333) offline install: use generic fetcher for milvus-lite wheel Signed-off-by: Tommy Hughes <[email protected]>
* Fix: Make search section sticky to prevent collision with main content Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix: Implement holistic solution for sticky search section Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add Home page button above Resources in sidebar navigation Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add blue Home icon to match other sidebar icons Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add blue icons for Lineage and Permissions to match other sidebar icons Co-Authored-By: Francisco Javier Arceo <[email protected]> * Revert Lineage icon to original design while keeping blue color Co-Authored-By: Francisco Javier Arceo <[email protected]> * Revert lineage icon to use original graphApp icon Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update Home icon to have a house shape Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format Layout.tsx with yarn format Co-Authored-By: Francisco Javier Arceo <[email protected]> * Delete ui/src/graphics/LineageIcon.tsx --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Signed-off-by: Tommy Hughes <[email protected]>
…#5337) * Add documentation page to Feast UI with SDK, API, and CLI documentation Co-Authored-By: Francisco Javier Arceo <[email protected]> * Add symlink to docs directory for documentation page Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update DocumentationService with hardcoded documentation content for demo purposes Co-Authored-By: Francisco Javier Arceo <[email protected]> * Replace docs symlink with actual reference content Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update Documentation icon to blue, move to last position, and add horizontal lines between CLI sections Co-Authored-By: Francisco Javier Arceo <[email protected]> * Update documentation page with improved formatting and routing Co-Authored-By: Francisco Javier Arceo <[email protected]> * Fix tab switching in documentation page Co-Authored-By: Francisco Javier Arceo <[email protected]> * Simplify Rollup configuration to fix build issues Co-Authored-By: Francisco Javier Arceo <[email protected]> * Format rollup.config.js with trailing commas Co-Authored-By: Francisco Javier Arceo <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…east-dev#5341) Revert "feat: Add CLI, SDK, and API documentation page to Feast UI (feast-dev#5337)" This reverts commit 203e888.
…v#5339) fix: Allow custom annotations to Operator installed objects Signed-off-by: Tommy Hughes <[email protected]>
* feat: Adding feast delete to CLI Signed-off-by: Francisco Javier Arceo <[email protected]> * Update sdk/python/feast/repo_operations.py * removing console.print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing console init Signed-off-by: Francisco Javier Arceo <[email protected]> * ignorng linter error Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]>
) feat: Added rest-apis option for registry server Signed-off-by: ntkathole <[email protected]>
chore: updated python documentation Signed-off-by: ntkathole <[email protected]>
…-dev#5336) * fix: upgrade protobuf version, make `protos` directory beforehand Signed-off-by: iamcodingcat <[email protected]> * feat: add aws s3 storage based registry store Signed-off-by: iamcodingcat <[email protected]> * chore: add aws s3 api related pkgs Signed-off-by: iamcodingcat <[email protected]> * style: remove my custom comment Signed-off-by: iamcodingcat <[email protected]> * refact: separate s3 registry file from `local.go` Signed-off-by: iamcodingcat <[email protected]> * feat: add if-statement in Makefile on linux arm64 os-platform Signed-off-by: iamcodingcat <[email protected]> * feat: add test-code for s3 registry store Signed-off-by: iamcodingcat <[email protected]> --------- Signed-off-by: iamcodingcat <[email protected]> Co-authored-by: 조영훈 <[email protected]>
…r" (feast-dev#5351) Revert "feat: Add s3 storage-based registry store in Go feature server (feast-dev#5336)" This reverts commit abe18df.
…ev#5353) fix: ignore_paths not taking effect Signed-off-by: joeyutong <[email protected]>
* patch upperbound limit for protobuf generation Signed-off-by: HaoXuAI <[email protected]> * patch upperbound limit for protobuf generation Signed-off-by: HaoXuAI <[email protected]> * patch upperbound limit for protobuf generation Signed-off-by: HaoXuAI <[email protected]> * patch upperbound limit for protobuf generation Signed-off-by: HaoXuAI <[email protected]> * update proto Signed-off-by: HaoXuAI <[email protected]> * update proto Signed-off-by: HaoXuAI <[email protected]> * update faiss version Signed-off-by: HaoXuAI <[email protected]> --------- Signed-off-by: HaoXuAI <[email protected]>
…ast-dev#5356) Signed-off-by: ntkathole <[email protected]>
# [0.55.0](feast-dev/feast@v0.54.0...v0.55.0) (2025-10-14) ### Bug Fixes * Added unix_timestamp_val in _serialize_val ([feast-dev#5659](feast-dev#5659)) ([35a8423](feast-dev@35a8423)) * BatchFeatureView transformation should persist in Registry Ser/Deserialization ([3364bad](feast-dev@3364bad)) * Check if DynamoDB table exists before create ([feast-dev#5658](feast-dev#5658)) ([e7fd506](feast-dev@e7fd506)) * Fix the link to Expedia in the Go Feature Server readme. ([3ed0163](feast-dev@3ed0163)) ### Features * Add Claude instructions ([feast-dev#5651](feast-dev#5651)) ([4807a52](feast-dev@4807a52)) * Groups and Namespaces based authorization, for Users and Service Accounts ([feast-dev#5619](feast-dev#5619)) ([da6257c](feast-dev@da6257c))
* added health endpoint for the UI Signed-off-by: Blake <[email protected]> * tests for the ui server Signed-off-by: Blake <[email protected]> * fixed formatting Signed-off-by: Blake <[email protected]> --------- Signed-off-by: Blake <[email protected]>
* feature(): support hdfs as registry Signed-off-by: Chimey Rock <[email protected]> * fix(): add type for HDFSRegistryStore Signed-off-by: Chimey Rock <[email protected]> * fix(): reformat code of registry.py file Signed-off-by: Chimey Rock <[email protected]> * fix(): change hdfs remove api and fix hdfs registry test Signed-off-by: Chimey Rock <[email protected]> * ci: install hadoop dependencies for pyarrow.fs.HDFSFileSystem Signed-off-by: Chimey Rock <[email protected]> * ci: fix install-hadoop-dependencies-ci Signed-off-by: Chimey Rock <[email protected]> * ci: typo in install-hadoop-dependencies-ci Signed-off-by: Chimey Rock <[email protected]> * ci: add HADOOP_USER_NAME env var Signed-off-by: Chimey Rock <[email protected]> * docs: add document for HDFS registry Signed-off-by: Chimey Rock <[email protected]> * fix: change wait logs of hdfs_registry test to ensure containers are running Signed-off-by: Chimey Rock <[email protected]> * ci: fix typo in install-hadoop-dependencies Signed-off-by: Chimey Rock <[email protected]> * docs(): Add pre-requisites for hdfs registry Signed-off-by: Chimey Rock <[email protected]> * ci(): cache hadoop tarball Signed-off-by: Chimey Rock <[email protected]> * ci(): rename hadoop-3.4.2 to hadoop Signed-off-by: Chimey Rock <[email protected]> * ci(): readd install-hadoop-dependencies-ci Signed-off-by: Chimey Rock <[email protected]> --------- Signed-off-by: Chimey Rock <[email protected]>
Signed-off-by: ntkathole <[email protected]>
…terialization logic (calling it) Signed-off-by: lukas.valatka <[email protected]>
) Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]>
…feast-dev#5678) * feat: Add flexible commandArgs support for complete Feast CLI control Signed-off-by: Blake <[email protected]> * missed trailing pipe Signed-off-by: Blake <[email protected]> --------- Signed-off-by: Blake <[email protected]>
* add NodeSelector support to config Signed-off-by: Blake <[email protected]> * code review updates Signed-off-by: Blake <[email protected]> * contrived example was actually wrong Signed-off-by: Blake <[email protected]> * removing incorrect docs Signed-off-by: Blake <[email protected]> * docs are not working with description Signed-off-by: Blake <[email protected]> --------- Signed-off-by: Blake <[email protected]> Co-authored-by: Francisco Arceo <[email protected]>
zabarn
reviewed
Jan 27, 2026
Comment on lines
337
to
358
There was a problem hiding this comment.
Looks like a bug was introduced here with the additional occurrence of:
(fields_with_aliases, aliases) = _get_fields_with_aliases(
fields=join_key_columns + feature_name_columns + [timestamp_field],
field_mappings=data_source.field_mapping,
)
fields_with_alias_string = ", ".join(fields_with_aliases)
After
(fields_with_aliases, aliases) = _get_fields_with_aliases(
fields=join_key_columns + feature_name_columns + timestamp_fields,
field_mappings=data_source.field_mapping,
)
fields_with_alias_string = ", ".join(fields_with_aliases)
Was already present
The second call overwrote the variables from the first call, but it only included [timestamp_field] instead of timestamp_fields (which contained both timestamp_field and created_timestamp_column).
Open Source only has the first occurrence
Bug caused both tests in test_compute_dag.py to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pulls in over a year's worth of changes from the open source Feast project. Highlights of the changes:
entity key serializationversion 3.compute_enginesdirectory.feature_builderpattern withnodesfor various filters and aggregations.sparkcompute engine which is currently enabled for theexpediaprovider.created_timestampandlast_updated_timestampfields.onlinestoresproject structure to remove thecontribdirectory, everything previously under that path has been moved intoonlinestores.Which issue(s) this PR fixes:
Misc