Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Non-privileged users shouldn't be able to click 'Edit' button in relationship field #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shbchk opened this issue Aug 22, 2023 · 4 comments · Fixed by #3726 · May be fixed by #4828
Open

Non-privileged users shouldn't be able to click 'Edit' button in relationship field #3718

shbchk opened this issue Aug 22, 2023 · 4 comments · Fixed by #3726 · May be fixed by #4828
Labels
Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on.

Comments

@shbchk
Copy link

shbchk commented Aug 22, 2023

EE 7.3.11

Video:

video-convert-1692716828834.webm
@intoeetive intoeetive added the Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on. label Aug 23, 2023
intoeetive added a commit that referenced this issue Aug 25, 2023
… even for entries where user had no permissions
intoeetive added a commit that referenced this issue Aug 29, 2023
… even for entries where user had no permissions
@shbchk
Copy link
Author

shbchk commented Oct 8, 2023

@intoeetive there are still edit links available in a relationship field:
video-convert-1696780647263.webm

EE 7.3.12

@intoeetive
Copy link
Contributor

@shbchk am I assuming correctly that the use has some permissions on Filmmamkers channel (e.g. create new entries) but does not have"edit entries" permission? Can you make a screenshot of how the permissions look like?

@intoeetive intoeetive reopened this Oct 9, 2023
@shbchk
Copy link
Author

shbchk commented Oct 9, 2023

Yes, your assumption is correct. A member has some permissions: create entries and edit their own entries.

image

@intoeetive
Copy link
Contributor

This was mostly working correctly as per EE 7.4.11, except for the case where there was AJAX call for loading more entries

Additionally, "edit" link was missing for newly created entries using the modal.

The referenced PR is getting the remaining stuff done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on.
Projects
None yet
2 participants