-
Notifications
You must be signed in to change notification settings - Fork 127
Channel form inline errors {field_errors} tag pair #4849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just for clarification... this is the result when using the {fieldl_errors} tag pair... we need to add some additional variables to this |
Gut is that we should have field_label, field_name etc. available here... so we give details on issues at top of form when desired etc. |
2 things here:
I'll submit PRs for both |
Oh man- yes, {field} works. It does still sort of duplicate- I get:
So just needs a doc fix and clean up the duplicates and maybe add more variables. So {label} I would definitely want, {field} would be the custom field short name (seo_title for example above), and then field_id_x might be useful to have, but I can't think of what to call it. |
Uh oh!
There was an error while loading. Please reload this page.
The {field_errors} tag pair just outputs the error - no label or any indication of what the error is in relationship to. It also looks like it shows double the errors.
So if you have 2 missing required fields you get:
This field is required.
This field is required.
This field is required.
This field is required.
I see where that happens- there's one error for field_id_x key and one for the actual label- in the channel_form_lib.php around 1602.
We need to either give them a {label} variable or include the label in the {error} like it's done in the message when not using inline errors. And also not double it up.
The text was updated successfully, but these errors were encountered: