Resolved #924 where template routing did not work properly with optional segments #4477
Conversation
There was a problem hiding this comment.
@intoeetive I haven't tested this but looking at the code would it be better to do rtrim and just focus on the trailing slash like your comment says?
There was a problem hiding this comment.
Tested locally on 7.4.11 and seems to work. My template route is:
/(uk|london|manchester|bristol|brighton)/search/{page:pagination}
When I apply the patch urls with optional segments are working as expected:
http://localhost:3000/london/search
http://localhost:3000/london/search/P20
whereas without the patch http://localhost:3000/london/search resolves to a 404.
|
On further testing it seems as though this fix doesn't fully work. It seems to work okay as outlined above but with a more complex route it seems not to work. For example I have this template route: /(uk|london|manchester|bristol|brighton)/search/{segment_3:alpha_dash}/{page:pagination} With the fix applied the following urls still give a 404 not found error /london/search |
|
@adster101 thank you for reporting this. Pushed the change that would hopefully fix the issue (you would need to re-save the routes to make it work) @bryannielsen need a good review here as well as some testing. The regex wasn't build correctly to consider multiple optional segments - previously, the slash was marked as optional, but the segment stayed required. I also tried to make it avoid extra unnecessary group nesting. |
Resolved #924 where template routing did not work properly with optional segments