Make no_results work in rss parser add-on #4833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs say that {if no_results} works, but it didn't. If there were no items, it still showed the feed meta data and just nothing for the missing items. If the tag was present, it and the contents were removed.
I'd personally like a way to show the feed meta data and a no results type tag for the items, but that's not consistent with what docs say or what user needed and given I haven't had any request for that, I'm being pedantic.
Hence- this simple 'Make no results work like normal' pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs say that {if no_results} works, but it didn't. If there were no items, it still showed the feed meta data and just nothing for the missing items. If the tag was present, it and the contents were removed.
I'd personally like a way to show the feed meta data and a no results type tag for the items, but that's not consistent with what docs say or what user needed and given I haven't had any request for that, I'm overthinking it.
Hence- this simple 'Make no results work like normal' pr.