feat: show project name either from config or from directory name #350
Conversation
|
Similarly to the other PR, I have pushed a new commit with the changes. I can amend the original one once approved. |
|
@F1bonacc1 what do you think about also having the project name on the title bar? I have a commit somewhere with that already and was doubtful about including it on this PR. |
Sounds interesting! Do you mean the terminal title bar or something else? |
|
yeah, on the terminal title bar: 
|
|
Yeah, I think it's a great idea, especially if one has more than one PC terminal tabs open. |
|
Done! |
F1bonacc1
left a comment
There was a problem hiding this comment.
Looks great. I left a few minor comments and suggestions.
F1bonacc1
left a comment
There was a problem hiding this comment.
Thank you, @jcmuller!
It looks great!.
I just don't want to break backward compatibility by removing the /hostname endpoint. I know there are some automations that use REST.
Let's have 2 separate endpoints::
/hostnamefor backward compatibility/project/namefor the new functionality
I hope you have time for this last change.
Thanks again!
F1bonacc1
left a comment
There was a problem hiding this comment.
I think there is another minor issue.
Please correct me if I am wrong.
Which is the host/server name + the name of the project if defined, otherwise CWD. Signed-off-by: Juan C. Müller <[email protected]>
Signed-off-by: Juan C. Müller <[email protected]>
Signed-off-by: Juan C. Müller <[email protected]>
|
|
Yeah, there was. Thanks! |
Show project name. If
nameis present in process-compose.yaml, display that. Otherwise, show the directory name.closes #346