feat: support http headers in probes #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmuller
commented
Jun 17, 2025
F1bonacc1
reviewed
Jul 15, 2025
Owner
F1bonacc1
left a comment
There was a problem hiding this comment.
Thanks!
Looks great.
A few questions and comments.
Contributor
Author
|
Done |
F1bonacc1
approved these changes
Jul 16, 2025
Owner
F1bonacc1
left a comment
There was a problem hiding this comment.
Looks great!
I think there are some minor conflicts, but other than that it's ready for merge.
fixes #255 Signed-off-by: Juan C. Müller <[email protected]>
Contributor
Author
|
Rebased, thanks! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #255