Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add process struct tags to help yamlls recognize non-required fields #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
F1bonacc1 merged 1 commit into from
Jul 16, 2025
Merged

fix: add process struct tags to help yamlls recognize non-required fields #356

F1bonacc1 merged 1 commit into from
Jul 16, 2025

Conversation

@adasauce
Copy link

@adasauce adasauce commented Jun 25, 2025

addresses comments in #332 about misrepresenting required fields.

@adasauce adasauce force-pushed the fix-schema branch 2 times, most recently from 14e471d to 243cce0 Compare June 25, 2025 02:25
F1bonacc1
F1bonacc1 approved these changes Jul 16, 2025
View reviewed changes
Copy link
Owner

@F1bonacc1 F1bonacc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Ready to merge once the conflicts are resolved.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adasauce
Copy link
Author

adasauce commented Jul 16, 2025

rebased on main and re-ran make schema to resolve the conflict.

note: it might help for maintainability if the json schema were pretty printed so it would be potentially easier to identify sources of change even though this is effectively a build artifact.

@F1bonacc1
Copy link
Owner

F1bonacc1 commented Jul 16, 2025

note: it might help for maintainability if the json schema were pretty printed so it would be potentially easier to identify sources of change even though this is effectively a build artifact.

Totally agree with that.
I think if we change this to MarshalIndent it will fix that:

process-compose/src/cmd/docs.go

Line 43 in 2cc46d1

data, err := json.Marshal(schema)

@adasauce
Copy link
Author

adasauce commented Jul 16, 2025

happy to have a look at it in another PR to keep it targeted.

@F1bonacc1
Copy link
Owner

F1bonacc1 commented Jul 16, 2025

happy to have a look at it in another PR to keep it targeted.

Makes sense. Thank you!

@F1bonacc1 F1bonacc1 merged commit 78f704a into F1bonacc1:main Jul 16, 2025
5 checks passed
@adasauce adasauce mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@F1bonacc1 F1bonacc1 F1bonacc1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adasauce @F1bonacc1