Devcontainer setup #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekpal1
reviewed
Dec 24, 2023
Member
vivekpal1
left a comment
There was a problem hiding this comment.
For now I can accept it by co-authoring, also donno much about python extensions if are they valid or not.
After pushing my co-authored changes @Mr-Sunglasses please review them and make valid changes
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "name": "paste.py", | |||
| "dockerfile": "Dockerfile", | |||
Member
There was a problem hiding this comment.
'dockerfile' key should be nested under 'build' context for clarity with the correct path. Also, 'extensions' is not a valid key at the root level.
| "python.linting.mypyEnabled": true, | ||
| "python.formatting.provider": "black" | ||
| }, | ||
| "portsAttributes": { |
Member
There was a problem hiding this comment.
'portsAttributes' is not a valid key. Use 'forwardPorts' to forward ports from the container.
| { | ||
| "name": "paste.py", | ||
| "dockerfile": "Dockerfile", | ||
| "extensions": { |
Member
There was a problem hiding this comment.
The 'extensions' object format is outdated. Use an array of strings for specifying extension IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22