WIP: printing used rlimit #3745
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a component in the output of --query_stats showing how much
rlimit was actually used by a query. Marking this WIP since it uses a
mutable variable to keep track of the previous rlimit-count, but this is
wrong and probably an approximation too. The right thing is issuing
another GetStatistics just prior to the check-sat and record the
original rlimit-count.
Example:
```
(ulib/FStar.ModifiesGen.fst(888,0-932,19)) Query-stats (FStar.ModifiesGen.modifies_intro_strong, 1) succeeded in 57 milliseconds with fuel 2 and ifuel 1 and rlimit 5 (used rlimit 0)
(ulib/FStar.ModifiesGen.fst(936,2-962,3)) Query-stats (FStar.ModifiesGen.modifies_intro_strong, 2) succeeded in 1347 milliseconds with fuel 2 and ifuel 1 and rlimit 20 (used rlimit 10)
(ulib/FStar.ModifiesGen.fst(936,2-962,3)) Query-stats (FStar.ModifiesGen.modifies_intro_strong, 3) failed {reason-unknown=unknown because unknown} in 2311 milliseconds with fuel 2 and ifuel 1 and rlimit 20 (used rlimit 20)
(ulib/FStar.ModifiesGen.fst(936,2-962,3)) Query-stats (FStar.ModifiesGen.modifies_intro_strong, 3) succeeded in 675 milliseconds with fuel 2 and ifuel 2 and rlimit 20 (used rlimit 5)
```
Would be nice to print some decimal points too, and/or the percentage of
total rlimit used.
|
This would be very useful. Untrusted F* could be shared with the minimum But as it is now, the only way to find this minimum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a component in the output of --query_stats showing how much rlimit was actually used by a query. Marking this WIP since it uses a mutable variable to keep track of the previous rlimit-count, but this is wrong and probably an approximation too. The right thing is issuing another GetStatistics just prior to the check-sat and record the original rlimit-count.
Example:
Would be nice to print some decimal points too, and/or the percentage of total rlimit used.