Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Standard error codes should use PascalCase. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2019
Merged

Standard error codes should use PascalCase. #16

merged 4 commits into from
Feb 22, 2019

Conversation

ejball
Copy link
Contributor

@ejball ejball commented Feb 17, 2019 •
edited
Loading

Standard error codes have always been PascalCase, but I somehow failed to remember that when I initially wrote this code.

@ejball ejball requested a review from ddunkin February 17, 2019 01:10
@ejball
Copy link
Contributor Author

ejball commented Feb 17, 2019

Are package-lock.json files supposed to be committed?

@ejball
Copy link
Contributor Author

ejball commented Feb 17, 2019

I noticed the test error locally, but figured a PR was the easiest way to inquire about it.

@ddunkin
Update build environment and and @types/node to Node.js 8.
e481548 
@types/node version wasn't specified, and newer versions have a more return complicated type for http.Server.address(). This fixes an error building the tests.

6 and 8 are both currently maintenance LTS, but 6 is about to be EOL.

package-lock.json was generated from npm 6.8.0.
ddunkin
ddunkin reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@ddunkin ddunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be on the v1 branch? It is a breaking change, right?

Yes, package-lock.json should be committed.

@ejball
Copy link
Contributor Author

ejball commented Feb 18, 2019

It's a breaking bug fix, so I wondered if I should make it available to v1 users.

But I suppose we could only make it available to v2 users.

@ejball
Copy link
Contributor Author

ejball commented Feb 18, 2019

Thanks for figuring out the issue.

@ejball ejball merged commit a0ffe0a into FacilityApi:v1 Feb 22, 2019
@ejball ejball deleted the pascal-errors branch February 22, 2019 17:07
@ejball ejball mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddunkin ddunkin ddunkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejball @ddunkin