Implemented UserAgent #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no tests yet but this is the case in the full core package. Lets ensure we add them when we have a clear overview if all is in here. |
bram-pkg
reviewed
Feb 20, 2025
Comment on lines
+16
to
+26
| /** @var string[] */ | ||
| private array $userAgents = ['firefox', 'chrome', 'internetExplorer', 'opera', 'safari', 'msedge']; | ||
|
|
||
| /** @var string[] */ | ||
| private array $linuxProcessor = ['i686', 'x86_64']; | ||
|
|
||
| /** @var string[ */ | ||
| private array $macProcessor = ['Intel', 'PPC', 'U; Intel', 'U; PPC']; | ||
|
|
||
| /** @var string[] */ | ||
| private array $windowsPlatformTokens = [ |
There was a problem hiding this comment.
Suggested change
| /** @var string[] */ | |
| private array $userAgents = ['firefox', 'chrome', 'internetExplorer', 'opera', 'safari', 'msedge']; | |
| /** @var string[] */ | |
| private array $linuxProcessor = ['i686', 'x86_64']; | |
| /** @var string[ */ | |
| private array $macProcessor = ['Intel', 'PPC', 'U; Intel', 'U; PPC']; | |
| /** @var string[] */ | |
| private array $windowsPlatformTokens = [ | |
| /** @var list<string> */ | |
| private array $userAgents = ['firefox', 'chrome', 'internetExplorer', 'opera', 'safari', 'msedge']; | |
| /** @var list<string> */ | |
| private array $linuxProcessor = ['i686', 'x86_64']; | |
| /** @var list<string> */ | |
| private array $macProcessor = ['Intel', 'PPC', 'U; Intel', 'U; PPC']; | |
| /** @var list<string> */ | |
| private array $windowsPlatformTokens = [ |
There was a problem hiding this comment.
This does exactly the same? What is the benefit of defining it as a list here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation port of useragent extension from Faker main lib to Core