Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump org.gradlex:gradle-module-metadata-maven-plugin to 1.2 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

Bump org.gradlex:gradle-module-metadata-maven-plugin to 1.2 #106

merged 1 commit into from
Jul 15, 2025

Conversation

jjohannes
Copy link
Contributor

With this users won't run into the following specific Gradle issue with future Jackson releases:
gradlex-org/gradle-module-metadata-maven-plugin#45

@cowtowncoder
Copy link
Member

cowtowncoder commented Jul 13, 2025 •
edited
Loading

Would it make sense to merge this against 2.19 branch instead? Or if possible maybe even 2.18 as that's planned to be our first LTS version.

@jjohannes jjohannes changed the base branch from 2.x to 2.18 July 13, 2025 19:16
@jjohannes jjohannes changed the base branch from 2.18 to 2.x July 13, 2025 19:16
@jjohannes
Copy link
Contributor Author

@cowtowncoder yes. This won't break anything. Feel free to change as you see fit. Or I can redo the branch against 2.18 tomorrow.

@jjohannes jjohannes force-pushed the deps-update-gradle-module-metadata-maven-plugin-1.2 branch from cbf7b8d to b5fc59e Compare July 14, 2025 07:00
@jjohannes jjohannes changed the base branch from 2.x to 2.18 July 14, 2025 07:00
@jjohannes jjohannes force-pushed the deps-update-gradle-module-metadata-maven-plugin-1.2 branch from b5fc59e to dc8a935 Compare July 14, 2025 07:01
@jjohannes
Copy link
Contributor Author

jjohannes commented Jul 14, 2025 •
edited
Loading

PR targets 2.18 now. Makes sense to do this for the (planned) LTS version.

EDIT: Just realized that this would include the <groupId> change which probably means that this adjustment has to be done in many other repos as well on the 2.18 branch. It's a straight forward adjustment though. But has to be done in several repositories.

@cowtowncoder
Copy link
Member

@jjohannes Oh. Good point. This increases risk by quite a bit -- so, let's actually target 2.x (for 2.20). Apologies for missing this & making you re-do changes.
It is intrusive enough change

We also need similar changes against 3.x, separate PR (since pom.xml changes do not merge well, alas).

@jjohannes jjohannes changed the base branch from 2.18 to 2.x July 15, 2025 15:46
@jjohannes
Bump org.gradlex:gradle-module-metadata-maven-plugin to 1.2
eb0e0e0 
With this users won't run into the following specific Gradle issue with
future Jackson releases:
gradlex-org/gradle-module-metadata-maven-plugin#45

Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes force-pushed the deps-update-gradle-module-metadata-maven-plugin-1.2 branch from dc8a935 to eb0e0e0 Compare July 15, 2025 15:50
@jjohannes
Copy link
Contributor Author

Retargeted to 2.x

@cowtowncoder
Copy link
Member

Just realized this is safe for 2.19 too, will backport after merging.

@cowtowncoder cowtowncoder merged commit 934c309 into FasterXML:2.x Jul 15, 2025
3 checks passed
cowtowncoder added a commit that referenced this pull request Jul 15, 2025
@cowtowncoder
Backport #106 from 2.20 to 2.19(.2)
c146c75
cowtowncoder added a commit that referenced this pull request Jul 15, 2025
@cowtowncoder
Merge pull request #107 from FasterXML/tatu/2.19/backport-106-from-2.20
833ee01 
Backport #106 from 2.20 to 2.19(.2)
@cowtowncoder
Copy link
Member

Merged, backported in 2.19 for 2.19.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjohannes @cowtowncoder