Fix bluetooth and relative symlinks#616
Open
newHeiko wants to merge 3 commits into
Open
Conversation
...to ensure symlinks to Bluetooth devices are found as well.
Leaves check if symlink points to serial port to searchForComPorts. Fixes Fazecast#567 also for relative symlinks.
danielb987
reviewed
Nov 24, 2025
| if (fcntl(port->handle, F_SETFL, flags)) | ||
| return 0; | ||
| if (setConfigOptions(port->handle, baudRate, &options)) | ||
| if (setCustomBaudRate(port->handle, baudRate)) |
There was a problem hiding this comment.
Is this change intended to be kept? If so, there doesn't seem to be any point of setting the options variable.
Author
There was a problem hiding this comment.
Yes, because 54bd919 removed setConfigOptions from the library and replaced it with setCustomBaudRate. It's not functionally a part of this change, just required to compile testPollPosix.
I also included is as a separate PR #615 before.
You are right that this was a quick hack to make testPollPosix compile and that it would be good to change/remove more code in testPollPosix. I'll leave it up to @hedgecrw to decide whether to keep this change or have a broken testPollPosix until someone does the full work.
Heiko
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the changes from #615.
It should fix #567 for relative links and links to bluetooth devices as well.