Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refine and clean the Turbo + Angular JSON manifest output #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025
Merged

Refine and clean the Turbo + Angular JSON manifest output #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
418acc8
Clean the Turbo + Angular manifest output
sjjj986 Aug 9, 2025
782c07d
Merge branch 'main' into sijin-turbo-with-angular
sjjj986 Aug 9, 2025
c24abef
lint
sjjj986 Aug 11, 2025
039f6c8
bump the angular adapter and common folder version
sjjj986 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@apphosting/adapter-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apphosting/adapter-angular",
"version": "17.2.15",
"version": "17.2.16",
"main": "dist/index.js",
"description": "Experimental addon to the Firebase CLI to add web framework support",
"repository": {
Expand Down
5 changes: 4 additions & 1 deletion packages/@apphosting/adapter-angular/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,10 @@ function extractManifestOutput(output: string): string {
if (start === -1 || end === -1 || start > end) {
throw new Error(`Failed to find valid JSON object from build output: ${output}`);
}
return stripAnsi(output.substring(start, end + 1));
// Clean the raw json string by removing the "web:build:" prefixes for a Turbo build
const prefixRegex = /\n?web:build:/g;
const cleanedOutput = output.substring(start, end + 1).replace(prefixRegex, "");
return stripAnsi(cleanedOutput);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/@apphosting/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apphosting/common",
"version": "0.0.6",
"version": "0.0.7",
"description": "Shared library code for App Hosting framework adapters",
"author": {
"name": "Firebase",
Expand Down