Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix SourceLink MSBuild flags #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2022
Merged

Fix SourceLink MSBuild flags #2019

merged 4 commits into from
Oct 22, 2022

Conversation

buvinghausen
Copy link
Contributor

@JeremySkinner the SourceLink integration for FluentValidation is broken you can verify that in NuGet Package Explorer

Assuming you do you CI builds in GitHub Actions which it looks like you do then just re-release as 11.2.3 and those flags should turn green.

@JeremySkinner
Copy link
Member

@buvinghausen thanks! I'll look at getting this into the next version. However please could you remove the <DebugType>embedded</DebugType> lines from the PR? These are are already present in the csproj so don't need to be added again

@buvinghausen
Copy link
Contributor Author

@JeremySkinner sure thing my bad

@JeremySkinner
Copy link
Member

Thanks!

I think even with these changes the package will be marked as Non deterministic as my publishing workflow involves compiling a release tag on my workstation rather than pushing directly from github actions to nuget (so I can manually verify the package).

Technically, the build is deterministic as it involves checking out a specific tag, so I guess I could always set <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>?

@JeremySkinner JeremySkinner mentioned this pull request Oct 21, 2022
Merged
@buvinghausen
Copy link
Contributor Author

buvinghausen commented Oct 21, 2022 •
edited
Loading

@JeremySkinner I will just change the condition attribute from GitHub Actions to build in release mode that should suffice

@JeremySkinner
Copy link
Member

Ah yes that's a good way to handle it. Thanks!

@JeremySkinner JeremySkinner merged commit 4ea9c0d into FluentValidation:main Oct 22, 2022
@JeremySkinner JeremySkinner added this to the 11.3 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@buvinghausen @JeremySkinner