This repository was archived by the owner on Nov 26, 2020. It is now read-only.
Expose font settings - closes #33#138
Merged
hebertialmeida merged 17 commits intoFolioReader:masterfrom Sep 16, 2016
Merged
Conversation
…tory/FolioReaderKit into feature/Pana/NativeJS
Source/FolioReaderAudioPlayer.swift
Outdated
| func speakSentence() { | ||
| guard let currentPage = FolioReader.sharedInstance.readerCenter.currentPage else { return } | ||
| guard let | ||
| _readerCenter = FolioReader.sharedInstance.readerCenter, |
Member
There was a problem hiding this comment.
I would avoid usage of _varName in Swift, it is not necessary.
Source/FolioReaderKit.swift
Outdated
| _readerCenter.currentPage?.webView.js("nightMode(\(nightMode))") | ||
| _readerCenter.pageIndicatorView?.reloadColors() | ||
| _readerCenter.configureNavBar() | ||
| _readerCenter.scrollScrubber?.updateColors() |
Member
There was a problem hiding this comment.
Why not use same name here? updateColors and reloadColors, let's pick one 😄.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains following changes:
FolioReaderinstead ofFolioReaderFontsMenu)