Fix incorrect menu on second highlight attempt#177
Fix incorrect menu on second highlight attempt#177hebertialmeida merged 1 commit intoFolioReader:masterfrom
Conversation
This fixes #170.
|
Yes, this is a good catch. It definitely fixed the second popup menu issue right after highlighted a sentence. |
|
@alexliubj, You can use my fork until this gets merged using |
|
Sorry guys, I am really busy these days, thanks @revolter for the PR and it is merged on master now. |
|
I understand. When you'll have time, some answers to my original questions would help too. |
|
This was reverted by eb72882 as per this comment. |
|
I think I am still experiencing this issue. And advise to fix it? The colour selection menu (also the menu with deletion) still popup periodically but the menu with 'highlight' is expected when the normal text is selected at the first time. |
|
@revolter Did you get a solution for this? |
This fixes #170.
I don't get what the logic is behind this. Why is
createMenucalled on menu dismiss, and not on menu show? Is it a sort of pre-rendering? What does thesetMenuVisible(true, andRect: rect)call do? As it clearly doesn't show the menu, as it is being dismissed at that point.Nonetheless, it looks like, somehow, on long tap, the correct menu appears all the time, so there's no need to force the "share" menu.