Create variable hidePageIndicator to hide page indicator.#196
Create variable hidePageIndicator to hide page indicator.#196hebertialmeida merged 5 commits intoFolioReader:masterfrom EmersonCarpes:master
Conversation
hebertialmeida
left a comment
There was a problem hiding this comment.
First of all, thank you for your contribution. Just requested few changes on your code.
Example/Podfile.lock
Outdated
| PODFILE CHECKSUM: 591559c46a2b0a49e687795b8ae46fadbddf8fd4 | ||
|
|
||
| COCOAPODS: 1.1.1 | ||
| COCOAPODS: 1.2.0.beta.1 |
There was a problem hiding this comment.
Let's not use the beta version for now, I think it is better to keep 1.1.1 which is the current stable.
| fileprivate func reloadViewWithPage(_ page: Int, _ hidePageIndicator:Bool = readerConfig.hidePageIndicator) { | ||
| let pagesRemaining = FolioReader.needsRTLChange ? totalPages-(totalPages-page+1) : totalPages-page | ||
|
|
||
| pagesLabel.isHidden = hidePageIndicator |
There was a problem hiding this comment.
I don't think here is the best place to hide that, because you are inside the page indicator.
Probably the best option is not to alloc and add the page indicator as subview, you can easily do that on viewDidLoad of the FolioReaderCenter.swift on line 166, where the page indicator is created. Just check for hidePageIndicator there.
This way the PageIndicator background will also be hidden.
…scroll-direction"" This reverts commit db508bb.
|
I believe that's all right now, could you check please? |
How can I disable PageIndicator #185