This repository was archived by the owner on Nov 26, 2020. It is now read-only.
FolioReaderCenter.getCurrentChapterName() issue, applied recursive search for toc reference.#342
Merged
hebertialmeida merged 7 commits intoFolioReader:masterfrom Jul 12, 2018
Merged
Conversation
…fter select any color in menu. https://github.com/FolioReader/FolioReaderKit/issues/316
…fter select any color in menu. https://github.com/FolioReader/FolioReaderKit/issues/316 (reverted from commit b8cccd7)
…ence. (reverted from commit 4577d99)
Member
hebertialmeida
left a comment
There was a problem hiding this comment.
It looks good to me, the only thing is the question about the removal of contentInsetAdjustmentBehavior
| view.addSubview(collectionView) | ||
|
|
||
| if #available(iOS 11.0, *) { | ||
| collectionView.contentInsetAdjustmentBehavior = .never |
Member
There was a problem hiding this comment.
This is a fix for a bug on iOS 11 collectionView scroll, why did you remove?
Contributor
Author
There was a problem hiding this comment.
Oh, sory sorry, i reverted incorrect commit.
Fixed! 658e0ba
Julyyq
added a commit
to Julyyq/FolioReaderKit
that referenced
this pull request
Apr 7, 2019
* 'master' of github.com:FolioReader/FolioReaderKit: (51 commits) Migrating documentation from cocoadocs to github pages Removing extra spaces Fix fast scroll bug (FolioReader#379) Migrated the Xcode project to use swift 4.2 Updated Cartfile to not use JSQWebViewController Bump minimum version support to iOS 9 and removed legacy JSQWebViewController Update FolioReaderKit.podspec Update README.md Update CHANGELOG.md Changed dependencies to work with iOS 12.1 and Xcode 10.1 (FolioReader#377) Fix crash on select segment at index. Swift 4.2 (FolioReader#361) Update issue templates method to get current progress between 0 and 100 (FolioReader#348) FolioReaderCenter.getCurrentChapterName() issue, applied recursive search for toc reference. (FolioReader#342) Fixed FolioReaderWebView, menu controller still showing colors menu after select any color in menu. (FolioReader#339) Fix iOS 11 auto adjust inset bug and closes #332 #312 #261 Update Cocoapods version Add Note function (FolioReader#335) Update LICENSE Fixed getCurrentChapter(), not returning some chapters, closes #302 thanks to @wesleycgs ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same error that was fixed in
FolioReaderCenter.getCurrentChapter().Fixed
FolioReaderCenter.getCurrentChapterName(), applied recursive search for toc reference.