This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Allow to set env variables based on commands #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FooSoft
suggested changes
Jul 10, 2017
Owner
FooSoft
left a comment
There was a problem hiding this comment.
First of all, I apologize for the slow reply -- I had limited access for the past week. Aside from the syntax change, this looks solid.
README.md
Outdated
| ["MYENV1", "foo"], # set MYENV1 to foo | ||
| ["MYENV2", "foo", "bar"], # set MYENV2 to foo,bar | ||
| ["MYENV3"], # clear MYENV3 | ||
| ["MYENV4", "!exec", "hostname", "-s"], # set MYENV4 to the output of `hostname -s` |
Owner
There was a problem hiding this comment.
Could you please change this to work more like:
["MYENV4", "!hostname", "-s"], # set MYENV4 to the output of `hostname -s`
I think that this would be more inline with how other parts of homemaker works, and it would at the same time get rid of the need for exec keyword.
Contributor
Author
|
Updated the PR as you suggested. |
Owner
|
Looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17