Updating kernel release script to update source files with tags and release in separate scripts #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8eec2f3 to
0cd5b0b
Compare
Member
There was a problem hiding this comment.
Overall I'm not a fan of this change. We're overloading the 'release' script to now perform multiple duties. When I call the release script - I expect to see a release. Not a source code update. Adding yet another parameter to the the release script both corrupts the purpose of this script as well as increases complexity.
I'd prefer to see the version number bump and any other source changes which occur broken into their own script. Breaking this out would ensure modularity and encourage reuse across our repos.
I'm happy to disagree and move forward if other team members feel that this change is simpler.
aggarg
reviewed
May 26, 2023
67666aa to
c26905f
Compare
Member
Author
@kstribrnAmzn make sense, I was trying to fix this with minimal modification to the existing script. Now I have modified the PR to do this separately as 2 different scripts, which should be a more maintainable solution. |
aggarg
approved these changes
May 29, 2023
Member
|
Thanks @tony-josi-aws! This is a lot more readable now :) |
kstribrnAmzn
approved these changes
May 30, 2023
moninom1
pushed a commit
to moninom1/FreeRTOS
that referenced
this pull request
Jun 26, 2023
…elease in separate scripts (FreeRTOS#1016) * separating source file updation to separate script * give execute permission to update_src_version.py
moninom1
added a commit
that referenced
this pull request
Jun 28, 2023
* Add IAR projects for LPC55S69 (#1007) * Add IAR projects for LPC55S69 * IAR Project for trustzone * MCUXpresso and IAR projects for non-trustzone (NTZ) ports Signed-off-by: Gaurav Aggarwal <[email protected]> * Fix build issues and warnings Signed-off-by: Gaurav Aggarwal <[email protected]> * Fix formatting check Signed-off-by: Gaurav Aggarwal <[email protected]> --------- Signed-off-by: Gaurav Aggarwal <[email protected]> * Set configMAX_SYSCALL_INTERRUPT_PRIORITY to 4 for QEMU demos (#986) * Update FreeRTOSConfig.h * Update FreeRTOSConfig.h * Update FreeRTOSConfig.h * Added Posix Demo run in github action (#997) * Added demo runs for Posix GCC in git action --------- Co-authored-by: Joseph Julicher <[email protected]> * Update FreeRTOSconfig.h for M2351 (#1005) The number of implemented priority bits for Armv8-M baseline implementation is defined by the architecture as 2. Therefore the config option `configPRIO_BITS` is updated to 2. In addition, in Armv8-M baseline implementation BASEPRI is RES0. Therefore, `configMAX_SYSCALL_INTERRUPT_PRIORITY` is not supported. Hence this config option is removed. Signed-off-by: Devaraj Ranganna <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> * Fix file path in the project file (#1013) Signed-off-by: Gaurav Aggarwal <[email protected]> * Add unit tests for kernel PR #679 (#1015) Also, fix the broken tests by that PR. Signed-off-by: Gaurav Aggarwal <[email protected]> * Update FreeRTOS-Kernel Source submodule * Updating kernel release script to update source files with tags and release in separate scripts (#1016) * separating source file updation to separate script * give execute permission to update_src_version.py * risc-v: Fix build flags and linker scripts (#906) 1. miss debug info in assembly code RISC-V-spike-htif_GCC LDFLAGS add arch and abi info for linker for riscv64-unknown-elf multilib, if there is no arch and abi info, will link to default lib and have below error target emulation `elf32-littleriscv' does not match `elf64-littleriscv' use CFLAGS to replace ASFLAGS when compile assembly code because DEBUG flag is added in CFLAGS, if we use ASFLAGS to compile assembly code, there is no debug info in assembly code objfile 2. binutils 2.39 ld warn 'has a LOAD segment with RWX permissions' RISC-V-Qemu-virt_GCC RISC-V-spike-htif_GCC RISC-V_RV32_QEMU_VIRT_GCC 3. fix build fail RISC-V_RV32_QEMU_VIRT_GCC Signed-off-by: Eric Chan <[email protected]> * Create GitHub Workflows that execute the p3 FreeRTOS Kernel Demos (#1018) * test full demo * Revert "test full demo" This reverts commit 09efa00. revert back to origin * pre-define user demo to blinky demo * pre-define user demo to blinky demo with -j * test run win32-msvc demo * test run win32-msvc demo * test run win32-msvc demo * update git workflow to run WIN32-MSVC demo * update git workflow to run WIN32-MSVC demo * update git workflow to run WIN32-MSVC demo * update git workflow to run WIN32-MSVC demo * update git workflow to run WIN32-MSVC demo * update git workflow to run WIN32-MSVC demo * update git workflow to run WIN32-MSVC demo * update trigger action * build and run WIN32-MSVC blinky demo * build and run WIN32-MSVC blinky demo * build and run WIN32-MSVC blinky demo * update WIN32-MSVC workflow * update WIN32-MSVC Demo main.c file to remove buffer * Update main.c files to remove buffer when running executable_monitor file for Git Action * update formatting for WIN32-MSVC demos * update formatting for Posix demo * update comment for setvbuf function used in main.c * add git build and run action for WIN32-MingW Full and Blinky demos; update main.c file to set buffer size as 0 * add git build and run action for WIN32-MingW Full and Blinky demos; update main.c file to set buffer size as 0 * remove whitespace for freertos_demos.yml file * add function to Force stdout to write immediately by setting the buffer size for it to 0 in demo main.c file when running git Run Action; Correct formatting error for WIN32-MingW main.c file * add function to Force stdout to write immediately by setting the buffer size for it to 0 in demo main.c file when running git Run Action * update git run action commands for Posix_GCC demo * update git run action commands for Posix_GCC demo * update git run action commands for Posix_GCC demo * reduce timeout and correct formatting issue * reduce timeout --------- Co-authored-by: Xiaodong Li <[email protected]> * Revert "Remove coroutines (#874)" (#1019) * Revert "Remove coroutines (#874)" This reverts commit 569c78f. * Update freertos Kernel submodule to latest head * Remove temporary files * Fix MingW demos and spell check * Fix manifest version; fix headers * Add ignore files and paths to core-checker.py * Fix copyright in remaining files * Fix PR check build failure 1. Remove defining `inline` in Makefile. This was causing build warnings. 2. Ensure that the linker removed unused functions from various compilation units. 3. Update the linker script so that all the functions are correctly placed in FLASH section. Signed-off-by: Gaurav Aggarwal <[email protected]> --------- Signed-off-by: Gaurav Aggarwal <[email protected]> Co-authored-by: Gaurav Aggarwal <[email protected]> * Adding CMakeList.txt in posix GCC demos (#1020) * Add cmake for posix GCC demo --------- Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> * Update File Header CI check failures --------- Signed-off-by: Gaurav Aggarwal <[email protected]> Signed-off-by: Devaraj Ranganna <[email protected]> Signed-off-by: Eric Chan <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> Co-authored-by: kar-rahul-aws <[email protected]> Co-authored-by: xuelix <[email protected]> Co-authored-by: Joseph Julicher <[email protected]> Co-authored-by: Devaraj Ranganna <[email protected]> Co-authored-by: Paul Bartell <[email protected]> Co-authored-by: Tony Josi <[email protected]> Co-authored-by: e14002270 <[email protected]> Co-authored-by: Xiaodong Li <[email protected]> Co-authored-by: Xiaodong Li <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Gaurav Aggarwal <[email protected]> Co-authored-by: chinglee-iot <[email protected]>
every-breaking-wave
pushed a commit
to every-breaking-wave/FreeRTOS
that referenced
this pull request
Nov 15, 2024
…dToAccessBuffer() (FreeRTOS#1016) * Add in a removed check for if a task is attempting to read a variable from a location it has write access to in xPortIsAuthorizedToAccessBuffer. * Add in a portDONT_DISCARD symbol as well.
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
…elease in separate scripts (FreeRTOS#1016) * separating source file updation to separate script * give execute permission to update_src_version.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Kernel release script to separate updating of source files with version tag and release in two separate scripts. This will enable generation of SBOM after the source files have been updated with version tags.
Test Steps
Tested on fork
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.