Fix logging issue causing mangled new lines #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardBarry
requested changes
Nov 8, 2020
muneebahmed10
approved these changes
Nov 9, 2020
RichardBarry
approved these changes
Nov 9, 2020
alfred2g
added a commit
to alfred2g/FreeRTOS
that referenced
this pull request
Oct 15, 2021
aggarg
pushed a commit
that referenced
this pull request
Oct 15, 2021
aggarg
added a commit
that referenced
this pull request
Nov 12, 2021
aggarg
added a commit
to aggarg/FreeRTOS
that referenced
this pull request
Nov 13, 2021
FreeRTOS#690)"" This reverts commit 7340a72.
aggarg
added a commit
that referenced
this pull request
Nov 15, 2021
johnrhen
pushed a commit
to johnrhen/FreeRTOS
that referenced
this pull request
Nov 24, 2021
FreeRTOS#690)"" This reverts commit 7340a72.
abhidixi11
pushed a commit
that referenced
this pull request
Dec 16, 2021
* Bring FreeRTOS-Kernel submodule pointer to V10.4.6 Signed-off-by: Gaurav Aggarwal <[email protected]> * Remove C89 flag from tests Signed-off-by: Gaurav Aggarwal <[email protected]> * Revert "UT: Add streambuffer test to make PR #391 pass (#690)" This reverts commit a861781.
moninom1
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Added comments to FreeRTOSIPConfigDefaults.h * Added entries to lexicon.txt * Revert kernel submodule pointer * Update include/FreeRTOSIPConfigDefaults.h comments 1 Co-authored-by: Aniruddha Kanhere <[email protected]> * Update include/FreeRTOSIPConfigDefaults.h 2 Co-authored-by: Aniruddha Kanhere <[email protected]> * Update include/FreeRTOSIPConfigDefaults.h 3 Co-authored-by: Aniruddha Kanhere <[email protected]> * Update include/FreeRTOSIPConfigDefaults.h 4 Co-authored-by: Aniruddha Kanhere <[email protected]> * A minor change: should becomes must Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]>
paulbartell
pushed a commit
to paulbartell/FreeRTOS
that referenced
this pull request
Mar 30, 2023
prvWriteMessageToBuffer wrote the first sbBYTES_TO_STORE_MESSAGE_LENGTH bytes of the size_t-typed length to the buffer as the data length. While this functions on little endian, it copies the wrong bytes on big endian. This fix converts the length to configMESSAGE_BUFFER_LENGTH_TYPE first, and then copies the exact amount, thus fixing the issue. Additionally it adds an assert to verify the size is not greater than the max value of configMESSAGE_BUFFER_LENGTH_TYPE; previously this would truncate silently. Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]>
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
* Fix logging issue caused by using \n as the default newline character * Update the other demos * Fix accidentally changed NETWORK_INTERFACE * Set \r\n as default instead * Update sources to reflect \r\n change * Get rid of configLOGGING_NEW_LINE altogether Co-authored-by: abhidixi11 <[email protected]>
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
UT: Add streambuffer test to make PR FreeRTOS#391 pass
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
FreeRTOS#690)"" This reverts commit 38a5e2c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Windows implementation of
vLoggingPrintfused\nas the default new-line character. However, the demos used\r\n, so it would append the extra parameters such aspcTaskNameto the end of each new-line message. This fixes it by setting the default new-line character to\r\n.In addition, any
configTASKPOOLmacros are removed as they are not being used at all.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.