Fix curl response parsing #7866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` instead Simply notify SimplePie of the redirect count before parsing
|
@Frenzie can you check again? used approach from FreshRSS/lib/simplepie/simplepie/src/File.php Line 164 in 288992d |
|
Oh yes, with a max number of redirects is obviously better. I'd overlooked that. :-) |
Alkarex
reviewed
Aug 28, 2025
Alkarex
reviewed
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #7760
After curl followed any redirects there would incorrectly be HTTP headers from the next response in the parsed response body.
Test feeds:
/favicon.icoto download the icon, got redirected and the default WordPress icon didn't download correctly due toisImgMime()failing when seeing HTTP headers at the beginninghtmlas the CSS selector and click preview, see headers: