Add hook enums #8036
Add hook enums #8036
Conversation
app/Controllers/feedController.php
Outdated
|
|
||
| /** @var string|null $urlHooked */ | ||
| $urlHooked = Minz_ExtensionManager::callHook('check_url_before_add', $url); | ||
| $urlHooked = Minz_ExtensionManager::callHook(Minz_HookType::CheckUrlBeforeAdd->value, $url); |
There was a problem hiding this comment.
| $urlHooked = Minz_ExtensionManager::callHook(Minz_HookType::CheckUrlBeforeAdd->value, $url); | |
| $urlHooked = Minz_ExtensionManager::callHook(Minz_HookType::CheckUrlBeforeAdd, $url); |
Suggestion, and for all similar calls. Requires function signature update. See below
There was a problem hiding this comment.
That was my ultimate goal. But I did not want to spend too much time if this was not the way to follow.
lib/Minz/ExtensionManager.php
Outdated
| * @param mixed ...$args additional parameters (for signature, please see Minz_HookType enum). | ||
| * @return mixed|void|null final result of the called hook. | ||
| */ | ||
| public static function callHook(string $hook_name, ...$args) { |
There was a problem hiding this comment.
| public static function callHook(string $hook_name, ...$args) { | |
| public static function callHook(Minz_HookType|string $hook_name, ...$args) { | |
| if ($hook_name instanceof Minz_HookType) { | |
| $hook_name = $hook_name->value; | |
| } |
|
I think that looks like a good step 👍🏻 |
|
Thank you for your input. I'll continue in that direction and I'll polish this PR. |
185c841 to
cf7a4bb
Compare
Change hard-coded string values to enums. This will allow a more robust code and a better understanding of the hook processes.
|
@Alkarex Whenever you have time! |
|
@Alkarex Should I sign my commits? This will rewrite the history though. |
No need for this one, but would be nice for future ones |
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.