Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Symfony 5 support #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2019
Merged

Symfony 5 support #201

merged 3 commits into from
Dec 23, 2019

Conversation

endroid
Copy link
Contributor

@endroid endroid commented Nov 21, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@endroid endroid changed the title Features symfony 5 Symfony 5 support Nov 21, 2019
@IonBazan IonBazan mentioned this pull request Dec 10, 2019
Merged
@michaljusiega
Copy link

Please bump the version to use with SF 5.0...

@mthiebaut
Copy link

Hello,

I'm interessed about this modification, can you merge this request?

billybraga added a commit to billybraga/FOSCKEditorBundle that referenced this pull request Dec 17, 2019
@billybraga
Apply FriendsOfSymfony#201 PR
3a1be68
@lsmith77 lsmith77 merged commit 7e1cfe2 into FriendsOfSymfony:2.x Dec 23, 2019
@lsmith77
Copy link
Member

please someone test 2.x to confirm if its working in a real world app .. and then I will tag a release

@nacholibre
Copy link

nacholibre commented Dec 28, 2019 •
edited
Loading

Just testing with symfony 5 using 7e1cfe2, ckeditor:install fails, but it works using the webpack!

user ✗ php bin/console ckeditor:install
----------------------
| CKEditor Installer |
----------------------

 // Downloading CKEditor ZIP archive from "https://github.com/ckeditor/ckeditor-releases/archive/full/latest.zip"

 1744510/1744510 [============================] 100%

 // Extracting CKEditor ZIP archive to "/Users/nacholibre/Development/nachoblog/vendor/friendsofsymfony/ckeditor-bundle/src/Resources/public"


In CKEditorInstaller.php line 256:

  Attempted to load class "ZipArchive" from the global namespace.
  Did you forget a "use" statement?


ckeditor:install [--release [RELEASE]] [--custom-build-id [CUSTOM-BUILD-ID]] [--tag [TAG]] [--clear [CLEAR]] [--exclude [EXCLUDE]] [-nobar|--no-progress-bar] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--] <command> [<path>]```

@lsmith77
Copy link
Member

hmm that issue would be caused if you don't have ext-zip installed https://www.php.net/manual/en/book.zip.php

but this dependency is listed in the composer.json:
https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/composer.json#L21

@nacholibre
Copy link

nacholibre commented Dec 28, 2019 •
edited
Loading

@lsmith77 ops, you are right, I don't have ext-zip, but I ran composer install with different php binary which had ext-zip installed, everything is fine then!

@lsmith77
Copy link
Member

ah cool .. so you can confirm that master is working fine with Symfony 5 ?

@nacholibre
Copy link

Yes, it's working.

@lsmith77
Copy link
Member

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/releases/tag/2.2.0

@jmsche jmsche mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@endroid @michaljusiega @mthiebaut @lsmith77 @nacholibre