-
Notifications
You must be signed in to change notification settings - Fork 84
Add support for Symfony 6.0 #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
artoroz
commented
Dec 1, 2021
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | /no |
License | MIT |
Maybe it's time.to drop unsupported versions of PHP? |
That would solve the problem of compatibility with phpunit 7 |
Any feedback on this? |
please merge it asap |
Also closes #240. |
I'd be interested to be able to use FOSCKEditorBundle with Symfony 6 too ;) |
Hi @lsmith77, is something needed for this to be merge ? :) |
a maintainer :-/ I am not using Symfony for a while now and too busy with my new role as co-founder in a startup. I fear @ElectricMaxxx also is no longer active on this bundle. |
changes look safe enough .. so merging but we need to someone take over maintenance and do a release. |
for anyone else finding themselves in here, because you read the last commit promising sf6 support, but then run into when installing via composer, use composer require friendsofsymfony/ckeditor-bundle:"@dev" to get the latest code with out the release :) |
Just be aware you are running a development version of the code which might not have been fully tested yet ;-). I prefer to wait for the next release for production environments. |
FYI I've been using artoroz's branch on production for more than a month without any issues. |
the situation is that there is currently not really a proper maintainer. so I would ask people to test this release and provide feedback here. if I see enough people confirming that things work fine, I can do a (last) release. Note the Bundle might become a UX component in the future: |
At this moment i am running at 2.x branch without any problems on production |
The 2.x branch is also working for me, with Symfony 6. |
ok cool .. sounds good. will do a release today or tmorrow |