Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

artoroz
Copy link
Contributor

@artoroz artoroz commented Dec 1, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? /no
License MIT

@jmsche
Copy link
Contributor

jmsche commented Dec 6, 2021

Maybe it's time.to drop unsupported versions of PHP?

@artoroz
Copy link
Contributor Author

artoroz commented Dec 6, 2021

Maybe it's time.to drop unsupported versions of PHP?

That would solve the problem of compatibility with phpunit 7
Also added check with php 8.1

@artoroz
Copy link
Contributor Author

artoroz commented Dec 14, 2021

Any feedback on this?

@FluffyDiscord
Copy link

please merge it asap

@0x6d6c 0x6d6c mentioned this pull request Dec 30, 2021
@0x6d6c
Copy link

0x6d6c commented Dec 30, 2021

Also closes #240.

@paulalbertdev
Copy link

I'd be interested to be able to use FOSCKEditorBundle with Symfony 6 too ;)

@VincentLanglet
Copy link
Contributor

Hi @lsmith77, is something needed for this to be merge ? :)

@lsmith77
Copy link
Member

lsmith77 commented Jan 7, 2022

Hi @lsmith77, is something needed for this to be merge ? :)

a maintainer :-/

I am not using Symfony for a while now and too busy with my new role as co-founder in a startup.

I fear @ElectricMaxxx also is no longer active on this bundle.

@lsmith77
Copy link
Member

lsmith77 commented Jan 7, 2022

changes look safe enough .. so merging but we need to someone take over maintenance and do a release.

@lsmith77 lsmith77 merged commit a4df405 into FriendsOfSymfony:2.x Jan 7, 2022
@w3sami
Copy link

w3sami commented Jan 19, 2022

for anyone else finding themselves in here, because you read the last commit promising sf6 support, but then run into
Problem 1
- Root composer.json requires friendsofsymfony/ckeditor-bundle 2.3.0 -> satisfiable by friendsofsymfony/ckeditor-bundle[2.3.0].
- friendsofsymfony/ckeditor-bundle 2.3.0 requires symfony/asset ^4.4 || ^5.0 -> found symfony/asset[v4.4.0, ..., v4.4.27, v5.0.0, ..., v5.4.0] but these were not loaded, likely because it conflicts with another require.

when installing via composer, use composer require friendsofsymfony/ckeditor-bundle:"@dev" to get the latest code with out the release :)

@ChristianVermeulen
Copy link

when installing via composer, use composer require friendsofsymfony/ckeditor-bundle:"@dev" to get the latest code with out the release :)

Just be aware you are running a development version of the code which might not have been fully tested yet ;-). I prefer to wait for the next release for production environments.

@jmsche
Copy link
Contributor

jmsche commented Jan 19, 2022

FYI I've been using artoroz's branch on production for more than a month without any issues.

@lsmith77
Copy link
Member

the situation is that there is currently not really a proper maintainer. so I would ask people to test this release and provide feedback here. if I see enough people confirming that things work fine, I can do a (last) release.

Note the Bundle might become a UX component in the future:
https://twitter.com/lsmith/status/1479433042229870599?s=21

@artoroz
Copy link
Contributor Author

artoroz commented Jan 19, 2022

At this moment i am running at 2.x branch without any problems on production

@jontjs
Copy link

jontjs commented Jan 20, 2022

The 2.x branch is also working for me, with Symfony 6.

@lsmith77
Copy link
Member

ok cool .. sounds good.

will do a release today or tmorrow

@lsmith77
Copy link
Member

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/releases/tag/2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants