Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Symfony 3.4.12 issue with 1.x? #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrerom opened this issue Jun 25, 2018 · 8 comments
Closed

Symfony 3.4.12 issue with 1.x? #465

andrerom opened this issue Jun 25, 2018 · 8 comments

Comments

@andrerom
Copy link
Contributor

After update today to 3.4.12 we are seeing the following:
screen shot 2018-06-25 at 14 46 34

Not looked deeply at it yet, so for now just asking if someone has seen the same.

andrerom referenced this issue in ezsystems/ezplatform Jun 25, 2018
@andrerom
Copy link
Contributor Author

andrerom commented Jun 25, 2018

Ok, seems it's caused by new method added in Abstract in symfony: symfony/symfony@v3.4.11...v3.4.12#diff-5350dc763df30ada9d00563c115f6652R68

@dbu Seems the following code is a bit risky, either extend or not reuse event subscribers from another class?

public static function getSubscribedEvents(): array
{
return BaseSessionListener::getSubscribedEvents();
}

@spointecker
Copy link

Same here

@emodric
Copy link
Contributor

emodric commented Jun 25, 2018

@andrerom I don't know if there's any better way to disable setting the cache to private for user context based pages, but I would say no, at least not in Symfony 3.4. @Toflar was the original author of the patch (#435), he could have some more insights.

The original issue: #433

@Toflar
Copy link
Contributor

Toflar commented Jun 26, 2018

Well there's not much more insight to give. Decorating the listener is the only way to disable the core behaviour for versions lower than 4.1. I knew it's going to cause issues so I created a PR for Symfony 4.1 (symfony/symfony#26681) to make sure we can easily disable the behaviour without decorating the listener in newer versions. But yeah, for versions lower than 4.1 we just have to keep up with the changes of Symfony itself 😢

@Toflar
Copy link
Contributor

Toflar commented Jun 26, 2018

In Contao we're using a similar approach (not using the UserContext there) and it's already fixed. See contao/core-bundle@db8ed61. So in case anybody wants to help @dbu with a PR, that would be awesome 😄

@phibo23
Copy link

phibo23 commented Jun 26, 2018

we also encountered this issue while updating to ezplatform 2.1. our workaround is to stay on FOSHttpCacheBundle 1.3.13. The issue seems to be introduced with 1.3.14.

@dbu
Copy link
Contributor

dbu commented Jun 29, 2018

fixed in https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/1.3.16 - i will now update master and release 2.4.1

@dbu dbu closed this as completed Jun 29, 2018
@dbu
Copy link
Contributor

dbu commented Jun 29, 2018

i could use some help in #473 - tests fail on master and i don't really understand why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants