-
Notifications
You must be signed in to change notification settings - Fork 83
Symfony 3.4.12 issue with 1.x? #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok, seems it's caused by new method added in Abstract in symfony: symfony/symfony@v3.4.11...v3.4.12#diff-5350dc763df30ada9d00563c115f6652R68 @dbu Seems the following code is a bit risky, either extend or not reuse event subscribers from another class? FOSHttpCacheBundle/src/EventListener/SessionListener.php Lines 84 to 87 in 6726a23
|
Same here |
Well there's not much more insight to give. Decorating the listener is the only way to disable the core behaviour for versions lower than 4.1. I knew it's going to cause issues so I created a PR for Symfony 4.1 (symfony/symfony#26681) to make sure we can easily disable the behaviour without decorating the listener in newer versions. But yeah, for versions lower than 4.1 we just have to keep up with the changes of Symfony itself 😢 |
In Contao we're using a similar approach (not using the UserContext there) and it's already fixed. See contao/core-bundle@db8ed61. So in case anybody wants to help @dbu with a PR, that would be awesome 😄 |
we also encountered this issue while updating to ezplatform 2.1. our workaround is to stay on FOSHttpCacheBundle 1.3.13. The issue seems to be introduced with 1.3.14. |
fixed in https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/1.3.16 - i will now update master and release 2.4.1 |
i could use some help in #473 - tests fail on master and i don't really understand why. |
After update today to 3.4.12 we are seeing the following:

Not looked deeply at it yet, so for now just asking if someone has seen the same.
The text was updated successfully, but these errors were encountered: