AdvancedUserInterface support in checkUserCredentials #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
Great. Thank you!! |
There was a problem hiding this comment.
Please fix the coding standards.
And wouldn't it be better to use the UserChecker ?
|
Yes, better use UserChecker |
|
The pull Request #117 is the best option for implement the user flags. |
|
@victorpuertas should we merge the two PRs? |
|
@willdurand No. #117 should be merged instead of this one. the current PR is duplicating the logic of the user checker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to AdvancedUserInterface methods like isEnabled for check the user status in OAuthStorage implementation.