Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix compatibility to new Symfony FlattenException #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Oct 15, 2019

Not sure if this PR is longer needed as create was also added to the new FlattenException to avoid this BC Break in symfony/symfony@928363c#diff-234309116eb79dcc9603b3a49669e499 by @yceruto not sure which function will stay in 5.0 or if there will still be both.

Copy link
Contributor

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed to support backward/forward compatibility.

@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2019

Thank you @alexander-schranz.

xabbuh added a commit that referenced this pull request Oct 18, 2019
…r-schranz)

This PR was merged into the 2.6-dev branch.

Discussion
----------

Fix compatibility to new Symfony FlattenException

See https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/ErrorRenderer/Exception/FlattenException.php

Commits
-------

1647111 Fix compatibility to new Symfony FlattenException
@xabbuh xabbuh merged commit 1647111 into FriendsOfSymfony:master Oct 18, 2019
@alexander-schranz alexander-schranz deleted the patch-1 branch October 18, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants