Log from/to time parse and app by name#23
Merged
Conversation
Closed
Collaborator
Author
|
This PR now includes updating all FastEdge commands to use app name instead of app id. |
qrdl
reviewed
Mar 11, 2024
| id, err := getAppIdByName(args[0]) | ||
| if err != nil { | ||
| return fmt.Errorf("parsing app id: %w", err) | ||
| return fmt.Errorf("getting app id: %w", err) |
Collaborator
There was a problem hiding this comment.
Since it is CLI that directly communicates with user it would be nice to show more human-readable error messages, such as "Cannot find app by name: ...". I know our guidelines require certain format for errors, but it is more about writing to the logs, but for the user we need to show something more understandable.
We need to keep it in mind with CLI, I know I'm also guilty of writing unfriendly error messages
Collaborator
Author
There was a problem hiding this comment.
Agree, pushing change.
qrdl
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after github.com/G-Core/FastEdge-client-sdk-go is updated.