Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mpsonntag
Copy link
Contributor

@mpsonntag mpsonntag commented Jul 31, 2018

When running parsers and converters with python2 it frequently happened to receive an encoding error while opening a file. Hopefully now encoding and usage of unicode is used everywhere where it is needed.

This PR also adds a new private attribute _origin_file_name to the doc entity. When an odML document is loaded from file, this attribute is now set with the file name from whence the document was loaded. When writing an RDF file from an odML document that features an _origin_file_name the value is exported as odml:hasFileName.

The PR also makes xml the default ODMLWriter format when writing a document to RDF since the xml format of RDF is still the format with the broadest acceptance.

@coveralls
Copy link

coveralls commented Jul 31, 2018

Coverage Status

Coverage decreased (-0.04%) to 81.733% when pulling 7e60996 on mpsonntag:fixConversionEnc into 04b408f on G-Node:master.

Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@achilleas-k achilleas-k merged commit 8d455d1 into G-Node:master Aug 1, 2018
@mpsonntag mpsonntag deleted the fixConversionEnc branch August 1, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants