Clone id handling changes #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odml.Validation attribute 'type' was renamed to 'rank'.
Give the option to keep the uuid when a property is cloned; default is to create a new uuid for a cloned property.
Closes G-Node#259, closes G-Node#258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #258 and #259.
When cloning a
Sectionor aPropertyby default the id of any object is changed to a new UUID. The cloning methods now feature a newkeep_idattribute. If set toTrue, the cloned object and any cloned children retain their original id. This is meant to enable the creation of exact copies of Section-Property trees in different documents.With the introduction of new validation checks for identical ids within a document in PR #303 a document cannot be saved, if a cloned object with a kept id is added ensuring that ids remain unique within a document.