[Converter] Remove check for duplicate section names #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test for this are still failing as I did not remove the corresponding tests yet. The tests are directly manipulating the xml and don't work on the odML structure, and don't tell if this is actually a realistic case. |
mpsonntag
added a commit
to mpsonntag/python-odml
that referenced
this pull request
Nov 16, 2018
Closes G-Node#310 Previously all same named odml.Sections within a document got indexed upon conversion. With these changes, only same named odml.Sections that reside on the same level are indexed.
Contributor
|
Renaming of all same named sections within a document does not make sense, but renaming of same name on the same level should be kept. Therefore this PR is closed in favour of #312. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289 by removing checks for duplicate section names. I could not find an old odML version, in which it was possible to generate sibling sections having the same name, so this check might not be too important. Please tell me if this is wrong, so I can find another solution for #289.