Automatically Add IDs At Verison Conversion #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding UUIDs, when converting from odML version 1.0 to 1.1. If an ID already exists, it stays the same, if it is compatible with the python uuid types. Otherwise (also if empty) a new ID is created for the property.
Adding UUIDs, when converting from odML version 1.0 to 1.1. If an ID already exists, it stays the same, if it is compatible with the python uuid types. Otherwise (also if empty) a new ID is created for the section.
Adding UUIDs, when converting from odML version 1.0 to 1.1. If an ID already exists, it stays the same, if it is compatible with the python uuid types. Otherwise (also if empty) a new ID is created for the document.
mpsonntag
requested changes
Jun 18, 2019
Reduce redundancy in _add_id.
Add pprint method showing document information and section/ property tree. Related to issue G-Node#319.
Allow value = 0 set as int, not as empty value. Fixing issue G-Node#314.
Changing dtype confirmation, adding exceptions for dtypes possessing string type values to allow appending with new values. Fixing issue G-Node#318.
Changing dtype confirmation, adding exceptions for dtypes possessing string type values to allow expending with new values. Related to issue G-Node#318.
Related to issue G-Node#318.
mpsonntag
approved these changes
Jun 18, 2019
jgrewe
approved these changes
Jun 25, 2019
Member
jgrewe
left a comment
There was a problem hiding this comment.
few nit-picking details that can as well be patched later
odml/tools/version_converter.py
Outdated
|
|
||
| @staticmethod | ||
| def _add_id(element): | ||
|
|
odml/property.py
Outdated
|
|
||
| if not (dtypes.infer_dtype(new_value[0]) == "string" and self.dtype in dtypes.special_dtypes): | ||
| raise ValueError("odml.Property.append: " | ||
| "passed value data type does not match dtype!") |
Member
There was a problem hiding this comment.
somehow feels like it could/should be extracted
| p3 = Property('myprop', value=0, dtype=DType.int) | ||
| self.assertEqual(p3.value, [0]) | ||
| self.assertEqual(p3.values, [0]) | ||
|
|
Member
There was a problem hiding this comment.
we should also test the boolean case
For append and extend methods, inferred and expected dtype are listed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request:
value=0#314