Import ABC from collections.abc instead of collections for Python 3.9 compatibility. #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniket-Pradhan
suggested changes
Feb 7, 2020
Contributor
Aniket-Pradhan
left a comment
There was a problem hiding this comment.
Everything looks great. Just a small nit.
Thanks a lot for your help here. ^.^
odml/base.py
Outdated
|
|
||
| try: | ||
| from collections.abc import Iterable | ||
| except: |
Contributor
There was a problem hiding this comment.
Can you please replace except with except ImportError
This would maintain uniformity and help us make sure that we are not skipping any other unwanted exception alongside as well.
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch. I missed it. Should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350