-
Notifications
You must be signed in to change notification settings - Fork 30
Property values cardinality implementation #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As further basis for discussion here is an outline of the current cardinality features:
|
achilleas-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I assume most of this functionality will be reused for Section->Section and Section->Property.
|
When we have figured out the details in the discussion, the concept will also be applied to cardinalities of Sections and Properties, yes. |
When setting a values cardinality and the current number of values violate the cardinality a warning is printed to the user.
|
I'm preparing tests for all new features and will push them once we are happy with the current state of the PR. |
|
Pushed tests for hopefully all added features. |
Windows does not support fetching the systems stdout via the 'sys.__stdout__' magic method in all cases.
|
@jgrewe I guess you want to review the changes since your approval before merging? |
This PR is supposed to show by example how a cardinality implementation (see issue #361) could look like and provides more grounds for discussion.
The current PR adds the basic cardinality implementation for Property.values. It provides
format.Property.__init__.val_cardinalityaccessor methods.Tests will still be pushed to this PR.
The PR should serve as a basis for discussion before the cardinality feature can be extended to sections and properties as well.