Adding Section sections cardinality #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a set Section section cardinality convenience method.
Adds test for both sec_cardinality setter and the set_sections_cardinality convenience method.
Add tests for saving and loading of the added Section.sec_cardinality attribute.
Adds tests for the Section sub-section cardinality validation. Once the ValidationError obj provides an id attribute, the tests should be refactored.
Member
|
Want a second review or are we good to merge? |
jgrewe
approved these changes
Apr 20, 2020
Member
jgrewe
left a comment
There was a problem hiding this comment.
lgtm, but still I would like to throw in the type-based restrictions, what do you think?
Member
|
I think we should open an issue about it and see what people think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR adds the basic cardinality implementation for Section.sections. It
Section.__init__.Section.sec_cardinalityaccessor methods.Section.set_sections_cardinalityconvenience method.The PR refers to issue #361.