Minor issue fixes and test reorganisation #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing deprecation and other specific messages via the 'warnings' module enables users to filter these messages. The added function on init level replaces the default 'warnings' print message with a less intrusive one for the whole package.
All usages of the Property attribute 'value' now elicit a 'warnings' DeprecationWarning.
Closes G-Node#360 Using the 'value' attribute with the create_property method now elicits a 'warnings' module deprecation warning.
All tests writing to file now use the central test directory from test/util and clean up after they are done.
Related to issue G-Node#387
Windows fails with a TypeError when handing an empty variable to os.path.exists().
achilleas-k
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of minor issues and reorganises the way tests handle temporary and resource files.
warningsmodule.Property.valueattribute deprecation warnings have been unified. Closes Unify deprecated 'Property.value' handling #360.test/resourcesdirectory.