rdflib dependency update, preparation release v1.5.3 #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of RDF Seq items has changed from rdflib version 5 to 6. The intruduced changes support both library versions.
When saving odml values to an RDF file, use the rdflib version 6+ handling as the default handling.
Remove the rdflib 5.0.0 pin and upgrade to the latest rdflib distribution. Also upgrade dependent test library owlrl and remove the pinned pyparsing version that rdflib 5.0.0 was dependent on.
The rdflib dependency requires Python 3.7+. Update the "untested package" notice on install from Python < 3.6 to < 3.7.
The rdflib > 6.0.0 requires Python 3.7. The introduced changes still support the odml package installation with a Python version < 3.7 and an rdflib version pinned to 5.0.0.
Remove tests for Python < 3.7 due to updated rdflib version.
Remove tests for Python < 3.7 due to updated rdflib version.
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 91.27% 91.02% -0.26%
==========================================
Files 64 64
Lines 8942 8965 +23
==========================================
- Hits 8162 8160 -2
- Misses 780 805 +25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
achilleas-k
reviewed
Apr 19, 2023
Member
achilleas-k
left a comment
There was a problem hiding this comment.
LGTM in general. Couple of small comments.
odml/tools/rdf_converter.py
Outdated
| print("Could not parse rdflib version %s" % rdflib_version) | ||
| return 0 | ||
| elif not version_split[0].isdigit(): | ||
| print("Could not parse rdflib version %s" % rdflib_version) |
Member
There was a problem hiding this comment.
If this is printed, the next line will cause an exception. Is that what we want? Should it instead return 0 like above?
Contributor
Author
There was a problem hiding this comment.
Good catch, this should probably return 0 as well.
README.md
Outdated
| ## Previous Python versions | ||
|
|
||
| Python 2 has reached end of life. We will not keep any future versions of odml Python 2 compatible and will completely drop support for Python 2 with August 2020. We also recommend using a Python version >= 3.6. If a Python version < 3.6 is a requirement, the following dependency needs to be installed as well: | ||
| Python 2 has reached end of life. We will not keep any future versions of odml Python 2 compatible and will drop support for Python 2 with August 2020. We also recommend using a Python version >= 3.7. If a Python version < 3.7 is a requirement, the following dependency needs to be installed as well: |
Member
There was a problem hiding this comment.
Could change the tense here for Python 2 since it's been almost 3 years to say:
Python 2 has reached end of life. Current and future versions of odml are not Python 2 compatible. We removed support for Python 2 in August 2020 with version x.y.z.
Contributor
Author
There was a problem hiding this comment.
Very good suggestion, will change it in readthedocs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rdflib library version upgrade from 5 to 6 introduced breaking changes and dropped support for Python versions < 3.7.
This PR
scripts/release_testscripts are still available and functional to check basic installation and usage of the odml library for all Python versions 3.5 - 3.10 for installation from source and package installation from PyPITest and PyPI proper.info.jsonis updated to reflect the officially supported Python versions and the odml package version number is updated to v1.5.3.Also successfully tested a package release on Test PyPI including installation of the odmltools and nixodmlconverter packages.