Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@heplesser
Copy link
Contributor

Currently setup.py requires pathlib, which leads pip to install the outdated and no longer maintained pathlib package which is not compatible with Python 3.10 or later (collections.Sequence is now collections.abc.Sequence).

Since pathlib has been part of the standard Python library since Python 3.4, it is not necessary to install it, as it is there by default. Therefore, this PR removes pathlib from the list of requirements.

I'd appreciate a quick merge and release on PyPi, since this problem breaks things so badly that you cannot even deactivate your conda enviroment after pip-installing python-odml.

Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

coverage: 80.753%. remained the same
when pulling 5d9acb8 on heplesser:remove-pathlib
into 5213865 on G-Node:master.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5213865) 91.02% compared to head (90ef0f3) 91.02%.

Files Patch % Lines
setup.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files          64       64           
  Lines        8961     8961           
=======================================
  Hits         8157     8157           
  Misses        804      804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heplesser
Copy link
Contributor Author

@jgrewe I noticed that several tests fail. Concerning the legacy linux failure, this seems to be related to a change in importlib, which causes problems for rdflib when using Python < 3.8. There is a workaround (see https://stackoverflow.com/questions/59216175/importerror-cannot-import-name-metadata-from-importlib#63159584) but that would have to be implemented in rdflib, and since Python 3.7 reached its end of life in June this year (https://devguide.python.org/versions/), it seems not right to ask the rdflib developers for such a change. Would you consider dropping Python 3.7 support so that this failure is not a problem? Also the macOS failure under 3.7 could be ignored then.

For Python 3.8 on macOS, I created a conda environment with Python 3.8 on my Mac (macOS 14.2) and could run python setup.py install and pip install -r requirements-test.txt there without problems. It installed pyyaml 6.0.1.

The macOS run for Python 3.10 seems to have been cancelled from the outside, not failed due to an error in the test process.

Do you have suggestions how to proceed?

@heplesser
Copy link
Contributor Author

BTW, Python 3.11 and 3.12 seem to be missing in your test roster.

@jgrewe
Copy link
Member

jgrewe commented Dec 14, 2023

@heplesser I am on it, there's also a deprecation warning I am going to fix in the same go ;)

@heplesser
Copy link
Contributor Author

Nice to see it all green now 👍

@jgrewe jgrewe merged commit 6866822 into G-Node:master Dec 15, 2023
@jgrewe
Copy link
Member

jgrewe commented Dec 15, 2023

@heplesser just made the release. Hope, things run smoothly again. Thanks a lot for your input!

@heplesser
Copy link
Contributor Author

@jgrewe Thanks for the fast release, problem solved 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants