-
Notifications
You must be signed in to change notification settings - Fork 30
Remove pathlib from requirements #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jgrewe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 64 64
Lines 8961 8961
=======================================
Hits 8157 8157
Misses 804 804 ☔ View full report in Codecov by Sentry. |
|
@jgrewe I noticed that several tests fail. Concerning the legacy linux failure, this seems to be related to a change in For Python 3.8 on macOS, I created a conda environment with Python 3.8 on my Mac (macOS 14.2) and could run The macOS run for Python 3.10 seems to have been cancelled from the outside, not failed due to an error in the test process. Do you have suggestions how to proceed? |
|
BTW, Python 3.11 and 3.12 seem to be missing in your test roster. |
|
@heplesser I am on it, there's also a deprecation warning I am going to fix in the same go ;) |
|
Nice to see it all green now 👍 |
|
@heplesser just made the release. Hope, things run smoothly again. Thanks a lot for your input! |
|
@jgrewe Thanks for the fast release, problem solved 👍 . |
Currently
setup.pyrequirespathlib, which leads pip to install the outdated and no longer maintained pathlib package which is not compatible with Python 3.10 or later (collections.Sequenceis nowcollections.abc.Sequence).Since
pathlibhas been part of the standard Python library since Python 3.4, it is not necessary to install it, as it is there by default. Therefore, this PR removespathlibfrom the list of requirements.I'd appreciate a quick merge and release on PyPi, since this problem breaks things so badly that you cannot even deactivate your conda enviroment after pip-installing python-odml.