fix(metrics): serve CSV downloads as UTF-8 so non-ASCII titles don't mojibake - #6322
Open
soroush5 wants to merge 1 commit into
Open
fix(metrics): serve CSV downloads as UTF-8 so non-ASCII titles don't mojibake#6322soroush5 wants to merge 1 commit into
soroush5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(metrics): serve CSV downloads as UTF-8 so non-ASCII titles don't mojibake
Fixes #6314
Hey! Noticed the CSV exports from the metrics dashboard were coming out
garbled for anything non-English — e.g.
Um novo índiceshows up asUm novo Ãndicewhen opened in Excel/Sheets. Two small things weremissing: the GA export never wrote a BOM, and the S3 upload never set
a content type/charset, so browsers and spreadsheets guessed latin-1.
What I changed
ga.py— write\ufeff(BOM) at the start of the CSV exports3_util.py— upload withContentType: text/csv; charset=utf-8How I verified
Added
metrics/tests/test_csv_encoding.pywith Portuguese (Um novo índice) and Korean titles — red before the fix (mojibake reproduced),green after. Existing metrics tests still pass.