Add close method to Reader #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great and makes sense to me! I don't see any issues with it, having called close() one should only expect that it's not possible to do anything on the file anymore. A possible extension of this would be to do the same for the Writer class, and implement Thanks! |
megies
added a commit
to megies/pyshp
that referenced
this pull request
Oct 15, 2017
karimbahgat
pushed a commit
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some testing frameworks and other utilities will print a warning when files are left open at the end of a test. I've added a
closemethod to theReaderclass that closes any files that may have been opened. Thisclosemethod is also called from__del__if theReaderobject is deleted/garbage collected. The warning I was getting is:I'm not super familiar with the internals of
Readerso there could be a chance that this could break anything returned by theReaderthat referencesshp,shx, anddbffiles and depends on them staying open.